[enc] Add a cat accessor to the booster. #11568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
trivialfis
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new categorical accessor (Cats()) on the C++ booster interface, refactors the C API and Python bindings to expose category data through a shared helper, and adds end-to-end tests comparing DMatrix and Booster category retrieval.
- Added
Cats()methods toLearnerandGBTreeto expose category containers. - Refactored C API
XGBDMatrixGetCategoriesand addedXGBoosterGetCategorieswith a sharedGetCategoriesImpl. - Extracted common Python
get_categorieslogic into_get_categoriesand updated tests to validate Booster category access.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/learner.cc | Added Cats() override on LearnerConfiguration to call through to GBM. |
| src/gbm/gbtree.h | Implemented Cats() in GBTree returning the model’s category container. |
| src/gbm/gbm.cc | Updated copyright years and removed unused includes. |
| src/c_api/c_api.cc | Moved category JSON logic into GetCategoriesImpl; added XGBoosterGetCategories. |
| python-package/xgboost/testing/ordinal.py | Added comp_booster tests to compare Booster vs. DMatrix categories. |
| python-package/xgboost/core.py | Introduced _get_categories helper and refactored DMatrix/Booster methods. |
| include/xgboost/learner.h | Declared forward CatContainer, updated GetNumFeature return type, added Cats(). |
| include/xgboost/gbm.h | Forward-declared CatContainer and provided default Cats() implementation. |
Comments suppressed due to low confidence (3)
include/xgboost/learner.h:231
- [nitpick] Method
Cats()deviates from the existingGet*naming convention (GetNumFeature,GetFeatureTypes). Consider renaming toGetCategories()orGetCatContainer()for consistency.
[[nodiscard]] virtual CatContainer const* Cats() const = 0;
include/xgboost/gbm.h:165
- [nitpick] The default implementation of
Cats()inGradientBoosterlogs a fatal error. To match otherGet*methods and improve clarity, consider renaming this method toGetCategories()or explicitly indicate it's unsupported.
[[nodiscard]] virtual CatContainer const* Cats() const {
src/c_api/c_api.cc:708
- When
cats.Empty()is true, the function sets*out = nullptrbut continues and then unconditionally overrides*out. Add areturnafter setting*out = nullptror restructure to avoid the override.
if (cats.Empty()) {
|
cc @rongou |
rongou
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11088